Improvements to AS3 docs that are not related to differences from AS2#5340
Merged
StephenBarlow merged 14 commits intorelease-3.0from Jul 9, 2021
Merged
Improvements to AS3 docs that are not related to differences from AS2#5340StephenBarlow merged 14 commits intorelease-3.0from
StephenBarlow merged 14 commits intorelease-3.0from
Conversation
glasser
force-pushed
the
glasser/as3-doc-pass
branch
from
84c9364 to
f6a46e7
Compare
glasser
force-pushed
the
glasser/misc-doc-fixmes
branch
from
bd003ee to
acc157c
Compare
glasser
force-pushed
the
glasser/as3-doc-pass
branch
from
f6a46e7 to
4060e1b
Compare
These are not AS3 regressions.
glasser
force-pushed
the
glasser/misc-doc-fixmes
branch
from
acc157c to
6b851b3
Compare
glasser
commented
Jul 2, 2021
| directive @deprecated( | ||
| reason: String = "No longer supported" | ||
| ) on FIELD_DEFINITION | ENUM_VALUE | ||
| ) on FIELD_DEFINITION | ARGUMENT_DEFINITION | INPUT_FIELD_DEFINITION | ENUM_VALUE |
Contributor
There was a problem hiding this comment.
cc @glasser
I did make the recommended update and agree with it, but it's worth noting that this is not in the spec yet (even in the working draft, surprisingly, though it's implemented in graphql-js)!
Member
Author
There was a problem hiding this comment.
Yep, this is the current PR: graphql/graphql-spec#805
We can leave it at the old version? I dunno.
glasser
commented
Jul 8, 2021
glasser
commented
Jul 8, 2021
Member
Author
glasser
left a comment
glasser
left a comment
There was a problem hiding this comment.
Other than those two notes this looks good! If you can resolve these, feel free to merge (I can't "approve" because it's "my" PR).
StephenBarlow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not AS3 regressions.